Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(weavedrive): use fetch in lieu of arweave js client to make graphql calls. Fix graphql operations. #382

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

TillaTheHun0
Copy link
Collaborator

@TillaTheHun0 TillaTheHun0 commented Oct 21, 2024

This PR fixes an issue in WeaveDrive, where a non-existent arweavejs client was being used to call an arweave gateway. The rest of the impl uses an internal api built around fetch, so I simply swapped the use arweavejs to using that api as well.

This PR also fixes malformed graphql queries that would fail, if made to an arweave gateway.

This PR also fixes a bug where module tags were being checked instead of process tags, when determining the Availablity-Type

Finally, I added tests to assert the correctness of loading txs in Availability-Types Assignments and Individual

the code changes are small -- the largest diff is the tests, which were previously unimplemented.

@TillaTheHun0 TillaTheHun0 changed the title fix(weavedrive): use fetch in lieu of arweave js client to make graphql calls fix(weavedrive): use fetch in lieu of arweave js client to make graphql calls. Fix graphql operations. Oct 28, 2024
@TillaTheHun0 TillaTheHun0 force-pushed the tillathehun0/weavedive-fetch branch from a9320e5 to 44fda6e Compare October 28, 2024 18:50
Copy link
Collaborator

@twilson63 twilson63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TillaTheHun0 TillaTheHun0 merged commit 3cb68d6 into main Oct 28, 2024
5 checks passed
@TillaTheHun0 TillaTheHun0 deleted the tillathehun0/weavedive-fetch branch October 28, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants